Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CSS text-anchor property #35167

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Added CSS text-anchor property #35167

merged 3 commits into from
Aug 2, 2024

Conversation

meyerweb
Copy link
Contributor

Description

Adds documentation of the CSS property text-anchor, which replicates an SVG attribute.

Motivation

The page currently doesn’t exist, and it needs to be created (see #34763).

@meyerweb meyerweb requested review from a team as code owners July 26, 2024 19:59
@meyerweb meyerweb requested review from chrisdavidmills and removed request for a team July 26, 2024 19:59
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/m [PR only] 51-500 LoC changed labels Jul 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 26, 2024 •
edited
Loading

Preview URLs

Flaws (1)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/text-anchor
Title: text-anchor
Flaw count: 1

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/dominant-baseline

(comment last updated: 2024-07-29 12:25:29)

@meyerweb meyerweb changed the title Added text-anchor property Added CSS text-anchor property Jul 26, 2024
bsmth
bsmth requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! All good except for the CSSInfo issue. Either we omit it or add an entry to mdn/data.

@meyerweb
Copy link
Contributor Author

meyerweb commented Aug 2, 2024

Thank you! All good except for the CSSInfo issue. Either we omit it or add an entry to mdn/data.

Per Josh-Cena’s comment in 35107, these should stay even if broken. (This is the case on several other CSS pages, in fact.) I can look into adding the information to mdn/data when I return from holiday, but in the meantime I believe this can be merged.

@bsmth
Copy link
Member

bsmth commented Aug 2, 2024

Thank you! All good except for the CSSInfo issue. Either we omit it or add an entry to mdn/data.

Per Josh-Cena’s comment in 35107, these should stay even if broken. (This is the case on several other CSS pages, in fact.) I can look into adding the information to mdn/data when I return from holiday, but in the meantime I believe this can be merged.

OK got it. I've opened a tracker in mdn/data so we don't forget!

bsmth
bsmth approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Eric!

@bsmth bsmth mentioned this pull request Aug 2, 2024
Open
7 tasks
@bsmth bsmth merged commit 58313ee into mdn:main Aug 2, 2024
8 checks passed
@meyerweb meyerweb deleted the css/text-anchor branch August 13, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena left review comments

@bsmth bsmth bsmth approved these changes

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills chrisdavidmills is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meyerweb @bsmth @Josh-Cena